Sends email confirmation link on registration #15

conradkleinespel · 2016-09-23T00:18:35Z

Fixes:
https://trello.com/c/3mwoNzld/90-pas-de-notification-votre-inscription-a-reussi-vous-allez-recevoir-un-lien-de-confirmation

This is not yet final but gives an idea of how things will work.

jgigault · 2016-10-01T16:09:07Z

controllers/dashboard/users.controller.js

+
+        sendEmailConfirmation(user, req, res, function(err) {
+          if (err) {
+            return next(err);


We should handle error here because err is defined when something really goes wrong on server (inserting data in database).
The other errors are simply notified, but err keep undefined

Sounds good !

…ead of exclusively failed login

jgigault force-pushed the conrad-emails branch from 655cd14 to bce8105 Compare Oct 1, 2016

jgigault reviewed Oct 1, 2016

View changes

jgigault force-pushed the develop branch from 1def066 to ebc5b3b Compare Oct 5, 2016

conradkleinespel and others added 2 commits Oct 11, 2016

sends email confirmation link on registration (and failed login) inst…

035deb1

…ead of exclusively failed login

handle error with sendEmailConfirmation

f93d9da

jgigault force-pushed the conrad-emails branch from e018d81 to f93d9da Compare Oct 11, 2016

customize message

fe9874d

jgigault merged commit 714afdd into develop Oct 12, 2016
2 checks passed

jgigault deleted the conrad-emails branch Oct 12, 2016

Sends email confirmation link on registration #15

Sends email confirmation link on registration #15

conradkleinespel commented Sep 23, 2016

jgigault Oct 1, 2016

conradkleinespel Oct 3, 2016

Sends email confirmation link on registration #15

Sends email confirmation link on registration #15

Conversation

conradkleinespel commented Sep 23, 2016

jgigault Oct 1, 2016

Choose a reason for hiding this comment

conradkleinespel Oct 3, 2016

Choose a reason for hiding this comment