Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sends email confirmation link on registration #15

Merged
merged 3 commits into from Oct 12, 2016
Merged

Sends email confirmation link on registration #15

merged 3 commits into from Oct 12, 2016

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Sep 23, 2016


sendEmailConfirmation(user, req, res, function(err) {
if (err) {
return next(err);
Copy link
Member

@jgigault jgigault Oct 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should handle error here because err is defined when something really goes wrong on server (inserting data in database).
The other errors are simply notified, but err keep undefined

Copy link
Contributor Author

@conradkleinespel conradkleinespel Oct 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good !

@jgigault jgigault merged commit 714afdd into develop Oct 12, 2016
2 checks passed
@jgigault jgigault deleted the conrad-emails branch Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants